scattergl lazy init #1444
Merged
scattergl lazy init #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- instead, create them on update when needed - this should speed up scattergl plotting especially when multiple traces are present - TODO: we'll need to reorder the trace object when adding a a 'mode' or an error bar to make sure e.g. lines are always drawn below scatter pts.
- at end of .update step - to preserve order on updates
etpinard
commented
Mar 3, 2017
| // - errorX | ||
| // - errorY | ||
| // - markers | ||
| this.scene.glplot.objects.sort(function(a, b) { |
There was a problem hiding this comment.
This part isn't quite right. We'll have to consider trace order too, fix coming on Monday.
The same technique might be extended to 3D to fix #1267
src/traces/scattergl/convert.js
Outdated
| obj._index = objIndex; | ||
| } | ||
| obj.update(options); | ||
| return obj; |
There was a problem hiding this comment.
what are the return obj statements for? Seems like it's meant for method chaining, but then wouldn't it be return _this? This way seems dangerous to me since obj can be (and very often is) null.
There was a problem hiding this comment.
or no, I guess not _this, but the object you create and return below
There was a problem hiding this comment.
Ha good eyes. I should've 🔪ed before pushing. We don't need to support method chaining here (why we anyone clear and/or update and/or dispose in the same statement?)
🔪 🔪 🔪
|
💃 nice 🐎 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of initialising 1
gl-line2d, 2gl-error2d, 1gl-scatter2dand 1gl-scatter2d-(fancy|sdf)object perscatterglwhy not intialize only the part(s) we need?On a 5-trace graph of 10,000 pts each, that amounts to a ~300ms-faster
plotcall 🐎