Fast color parsing

[dy]

Implement faster color parsing for the gl-scatter2d-sdf module.

[etpinard]

Can you add color-rgba to the package.json and push again?

I'll be interesting to see if the tests pass on CI ...

[dy]

@etpinard whoops, done.
Perf boost is noticeable only for large data sets in gl-scatter2d-sdf.
As for existing ~2s plotly.js lag the bottleneck is something different.

[dy]

@etpinard ok, it speeds up color parsing compared to the previous one, but in total it seems to be not the biggest bottleneck.

[etpinard]

@dfcreative any perf improvements are always welcome 🐎

Look like one 3D mock is failing though

[dy]

@etpinard fixed that case. Turned out some marker colors are (mistakenly) parsed from numbers, and color-parse treats numbers as possible color values.

[etpinard]

Looks like commit 22eacec broke a few things.

@dfcreative do you think you'll have the time to make the tests go ✅ again in the next few days? If not, I'll drop it from the 1.25.0 release, no big deal. If you do have the time to look at this, make sure to merge the latest master into this branch to make CI happy post-#1455.

[dy]

@etpinard yes, sure, I'll give it a shot tonight.

[dy]

@etpinard may I ask you to run baselines to show list of broken ones? I am having a hard time getting info from circleci. Would appreciate

[etpinard]

Sure. Merging master into this branch should help though.

[dy]

@etpinard there are two failed tests, looks like they are not related to colors. Should I try to reproduce them or it is transitional thing?

[etpinard]

Oh shit. Yeah I've seen those tests fail intermittently. Don't worry about them.

Thanks again for this PR 🎉

[etpinard]

Sweet. Tests are ✅ again.

Looks like the broken tests I mentioned in #1443 (comment) where simply due to [email protected] causing havoc as described in #1450 (comment). Commit 22eacec didn't actually break anything.

Thanks @dfcreative !!