Fix for xyz column heatmap trace 'text' on hover #1417
Conversation
- and use that to determine the text label on hover - in the case of XYZ column traces calc'3d has a different structure then fullData text, so it becomes important to use calc'ed text to hover text to work after non-do-calc interaction (e.g. zoom).
| if(Array.isArray(trace.text) && Array.isArray(trace.text[ny])) { | ||
| text = trace.text[ny][nx]; | ||
| if(Array.isArray(cd0.text) && Array.isArray(cd0.text[ny])) { | ||
| text = cd0.text[ny][nx]; |
There was a problem hiding this comment.
for xyz heatmaps, fullData[i].trace.text is 1D, whereas gd.calcdata[i][0].text is 2D.
Previously, fullData[i].trace.text was converted to be 2D during the calc step, but since the calc step isn't called on relayout(gd, 'xaxis.range', [/* */]), text on this line here was undefined after zoom interactions as discovered in #1391.
There was a problem hiding this comment.
wow, nice detective work!
There was a problem hiding this comment.
This looks fine as a bugfix, though I would think the more robust solution would not alter fullData at all, and only keep the re-dimensioned text array in calcdata.
There was a problem hiding this comment.
and only keep the re-dimensioned text array in calcdata.
I agree 100%. But, I wanted to keep this patch to a minimum as @rreusser's carpet PR already alters heatmap/convert_column_xyz.js.
I'll make a comment there.
fixes #1391