Skip to content

[EXPERIMENTAL] Run prettier --write #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[EXPERIMENTAL] Run prettier --write #1374

wants to merge 1 commit into from

Conversation

rreusser
Copy link
Contributor

This PR is an alternative to #1371 using prettier, which seems to be an alternative to eslint that people are pretty excited about. As opposed to eslint, prettier does not 'fix' any code or throw errors. Instead, it just 100% rewrites it from the AST so that you have no choice over formatting. Which is kind of the point of enforcing formatting in the first place.

Just submitting for the sake of discussion. Presumably this would be a precommit/prepublish hook instead of a yes/no pass/fail step.

@rreusser
Copy link
Contributor Author

rreusser commented Feb 13, 2017

prettierlists itself as beta and notes that it works fine but may undergo a few tweaks before it's fully stable. I saw someone from facebook saying they'd be fine using it in production if just a couple particular PRs were reviewed/merged.

@rreusser
Copy link
Contributor Author

Closing this. prettier-standard-formatter looks interesting, but seems maybe best to wait just a moment for prettier to stabilize.

@rreusser rreusser closed this Feb 13, 2017
@etpinard etpinard deleted the prettier branch March 17, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant