Contour auto persist #1338
Merged
Contour auto persist #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jan 30, 2017
| expect(gd.data[0].autocontour).toBe(true); | ||
| expect(gd.data[0].contours).toEqual({start: 0.5, end: 3.5, size: 0.5}); | ||
|
|
||
| Plotly.restyle(gd, {'z[0][0]': 10}); |
There was a problem hiding this comment.
Really. This works? That's awesome!
There was a problem hiding this comment.
This makes #144 obsolete.
|
💃 lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug I found when playing around with contours: If you make a contour plot without specifying anything about contours (so you get the full
autocontourbehavior even though it's not explicitly stated) then you change thezrange, it would not update the contour range. You can do this in straight plotly.js withPlotly.restyle, or in the workspace by making a contour plot and then modifying the data grid. Also ensures the correct level of replotting when you modify any part of an array, ie ifztriggers a recalc, so doesz[1],z[2][3], etc.Related to #1282 but for now I don't want to go all the way into that, I just want to fix the bug.
cc @etpinard