-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix bar marker color array legend style #1289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- as box traces don't have arrayOk style attribute at the moment
] | ||
], | ||
"layout": { | ||
"showlegend": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -172,13 +172,14 @@ function styleBars(d) { | |||
barpath.exit().remove(); | |||
barpath.each(function(d) { | |||
var w = (d.mlw + 1 || markerLine.width + 1) - 1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need d
-> d0
too? care to include line width and color arrays into the same mock?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good 👁️
Done in 8e718bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for completeness:
and color arrays
ie marker.line.color
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 81d3db1
"red", | ||
"green", | ||
"blue", | ||
"yellow" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A thing of beauty :)
💃 |
@etpinard, Im afraid this is occurring again in 2020. Could you take a look please? |
@nitramwin can you open a new issue with a codepen showing the problem you've encountered? |
@alexcjohnson This is my first time making a codepen - I hope this works. https://codepen.io/nitramwin/pen/mdEoxZo |
Thanks @nitramwin. Tracked in #5285. |
fixes #1212
... bringing legend support for bar maker color arrays on par with scatter.