Honor fixedrange: false in y-axes anchored to xaxis with range slider
#1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- define scoped coerce function once for all axes - only loop over xaxis list for rangeslider / rangeselector defaults
- replace with 'smart' defaults in cartesian layout defaults so that user set `fixedrange: false` will now be honored.
- this was never implemented - it was in there *just* to make the call to axisDefaults work
- rm now useless yaxis mocks - add better fixedrange logic test cases
|
ping range slider author #️⃣1️⃣ @mdtusz |
| counterAxes: {x: yaList, y: xaList}[axLetter].map(axisIds.name2id), | ||
| overlayableAxes: {x: xaList, y: yaList}[axLetter].filter(function(axName2) { | ||
| return axName2 !== axName && !(layoutIn[axName2] || {}).overlaying; | ||
| }).map(axisIds.name2id) |
There was a problem hiding this comment.
I don't suppose you want to use this opportunity to 🔪 these map and filter calls? And the (x|y)alist.forEach calls below?
There was a problem hiding this comment.
Yeah. That would be nice!
I want to clean up a few artefacts from the old axes.js module (which would help out @rreusser for carpets). Namely those annoying ._gd refs and get rid of the circular dependency between axes.js and plots.js. I'll make sure to remove those map / filter in that PR!
|
nonblocking comment only. 💃 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make a bunch of folks on https://community.plot.ly/ happy.
Ever since #1017, there's no reason to hard set
fixedrange: truefor all y-axes anchored to a x-axis that has a range slider: the range plot draw step can handle y-axis interactions.To preserve backward compatibility, we must however make sure that y axes anchored to a x-axis with a range slider default to
fixedrange: true. With this PR, users can now set backlayout.yaxis.fixedrange: falseif they prefer having interactive y-axes along with their range slider plots.