Convert arrayOk attribute to calcdata in calc step #1257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes calc-transforms behave as desired on relayout (e.g. zoom).
Moreover, it should also be a perf boost as trace array to calcdata is now called only in the calc as opposed to the plot step (which is called more often e.g. on zoom).
Now, this PR moved around some pretty ancient code. I'm a little afraid about possible regressions. I'm not 100% confident in our test suite for the various
restyle
call that depend onarraysToCalcdata
, I'll dig into our test suites to verify.