filters use valuecalendar and targetcalendar instead of calendar #1253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes filter attribute
calendar
tovaluecalendar
and adds a new onetargetcalendar
to use if an array is provided astarget
. Iftarget
is a string (ie referring to an attribute in the same trace) it will ignoretargetcalendar
and instead use the calendar for that attribute (soxcalendar
if target is'x'
) which is what it was doing previously.targetcalendar
to be specified, like if you're filtering ontext
or something that doesn't have its own calendar attribute? yeah, I'll do that.Note that this is a BREAKING change (calendar
if supplied is not coerced intovaluecalendar
) but only breaking what's been in master for the last 6 days since merging #1220@VeraZab @cldougl @chriddyp @etpinard