Skip to content

filters use valuecalendar and targetcalendar instead of calendar #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2016

Conversation

alexcjohnson
Copy link
Collaborator

@alexcjohnson alexcjohnson commented Dec 14, 2016

Changes filter attribute calendar to valuecalendar and adds a new one targetcalendar to use if an array is provided as target. If target is a string (ie referring to an attribute in the same trace) it will ignore targetcalendar and instead use the calendar for that attribute (so xcalendar if target is 'x') which is what it was doing previously.

  • hmm, maybe we should still allow targetcalendar to be specified, like if you're filtering on text or something that doesn't have its own calendar attribute? yeah, I'll do that.

Note that this is a BREAKING change (calendar if supplied is not coerced into valuecalendar) but only breaking what's been in master for the last 6 days since merging #1220

@VeraZab @cldougl @chriddyp @etpinard

@alexcjohnson
Copy link
Collaborator Author

added cleanData step to turn calendar into valuecalendar for backward compatibility

@etpinard
Copy link
Contributor

💃

@alexcjohnson alexcjohnson merged commit 5bce249 into master Dec 14, 2016
@alexcjohnson alexcjohnson deleted the filter-cals branch December 14, 2016 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants