-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[WIP] Carpet plots #1239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Carpet plots #1239
Changes from 118 commits
5ad7bb9
7e6858a
752d268
5c302aa
256ff18
1c064fc
3199d70
2016ae2
ce290ae
4e4c093
5aa52ce
2883068
c29fdf7
e384d80
b394ca1
6c8154c
e731152
bf203a0
fb002c8
714db5a
2e5fbe6
502f89a
98a660f
656a8db
56f9662
7fd160d
6651fdf
ef82074
dbf269f
17a6b52
dc2d76e
136f43c
36e2100
3c1ca75
82e86f3
c80a5e9
9ccdcfe
71efcf9
946c751
ec7ab18
eed5406
7304043
e4dc03c
490039c
8f8ea25
65eaf4c
acff100
4088ee8
223d120
5a11a85
263d5dc
646255f
ae0e3c8
01b0803
b708e32
9d99328
e09b97a
b17e7e5
05cd928
dfb9f3e
ac0945a
d54ae59
a2b89b0
e9865c0
8a9cbea
f65a109
52c0e04
4da8426
34c41cc
d15a450
af0bcea
7eefde2
cabeb06
564cf8d
df3b354
309d360
5e5a2ab
e43d716
310d61e
966e31e
cca3562
aa6c8a7
2f4b38b
a7521ae
047a93d
3ccce1a
8a34a20
41e35b4
1f79e08
6846186
dcfcd98
3f3b879
cdba832
d729673
06948e3
b466a02
291b5de
f053aa0
86345de
58261ef
fd32c25
992d97a
1046dd3
f98ae64
ea7a71f
977021a
4af500a
ca49a5a
9b4f2b4
7ac5f42
e577ad1
7e5e5ef
688516a
cd246e9
19a960b
30b0280
0136aa3
3f18627
1f69fef
ec6e519
d693fe5
e202957
30c9063
7d4b482
800971f
d94009e
11fafef
bcde707
172ea34
6c627d4
1eafd94
8f17dd6
3764da3
8307c9e
e3b6d2a
906220d
aedb473
8c7d00c
b4d0848
c88fae1
3f90a0b
c2af4c0
69b4d8b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright 2012-2017, Plotly, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
module.exports = require('../src/traces/carpet'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright 2012-2017, Plotly, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
module.exports = require('../src/traces/contourcarpet'); |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
/** | ||
* Copyright 2012-2017, Plotly, Inc. | ||
* All rights reserved. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
*/ | ||
|
||
'use strict'; | ||
|
||
module.exports = require('../src/traces/scattercarpet'); |
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
@@ -0,0 +1,11 @@ | ||||
/** | ||||
* Copyright 2012-2017, Plotly, Inc. | ||||
* All rights reserved. | ||||
* | ||||
* This source code is licensed under the MIT license found in the | ||||
* LICENSE file in the root directory of this source tree. | ||||
*/ | ||||
|
||||
'use strict'; | ||||
|
||||
module.exports = require('../src/traces/carpet'); | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm. This file doesn't do anything, right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it shouldn't be included by default, but see: Line 41 in 3f18627
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,15 @@ var extendFlat = require('../../../lib/extend').extendFlat; | |
|
||
|
||
module.exports = { | ||
visible: { | ||
valType: 'boolean', | ||
role: 'info', | ||
description: [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could reuse the declaration from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point. I blindly copied this definition in a rush since it broke gl3d plots entirely until it was present. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ✅ |
||
'A single toggle to hide the axis while preserving interaction like dragging.', | ||
'Default is true when a cheater plot is present on the axis, otherwise', | ||
'false' | ||
].join(' ') | ||
}, | ||
showspikes: { | ||
valType: 'boolean', | ||
role: 'info', | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe carpet traces should be part of the
cartesian
bundle?If
scatterternary
wasn't already in there I'd vote for no. But now that I realisescatteternary
is part of the cartesian bundle, I'm not so sure.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. I'm not sure exactly what's best for a default. Easiest for working was just to bundle it. But it's quite a bit of code, generally speaking, so that I feel like it will require some more nuanced per-bundle decisions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Let's leave carpet traces out of the cartesian bundle to start. We can always add then down the road in a future minor release if we choose to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a bundle which should include it by default?