-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
World calendars #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
World calendars #1220
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
d2a5e4b
simpleMap utility so we don't pass unexpected args
alexcjohnson 6151575
change gl2d_date_axes mock to date string axis range
alexcjohnson 4b9edec
add world calendar support part 1
alexcjohnson 4d8f79a
overhaul set_convert so I can tell where calendars go
alexcjohnson 84a51c2
add world calendar support part 2
alexcjohnson 13cf6b1
world-cals image mock
alexcjohnson 165125b
fix 3d calendar attributes
alexcjohnson 86b31ea
fix gl3d with world calendars
alexcjohnson 78b6646
test world-cals in scattergl & gl2d axes
alexcjohnson 1b563f5
test world calendars with finance charts
alexcjohnson 4e9a632
remove mistaken paste
alexcjohnson c1c24e8
support world cals in rangesliders
alexcjohnson a435981
partial support for range selectors on world calendars
alexcjohnson 6653da7
get the right date string replacement for candlestick mock
alexcjohnson 8e1747f
bigger tolerance on updatemenus_test width test
alexcjohnson 00ae2dd
fix and test layout.calendar inheritance
alexcjohnson 3143099
move world-calendar logic in lib/dates.js to new 'calendars' component
etpinard 5984106
coerce calendar attributes in calenders component
etpinard 03ab34f
add requirable 'calendars' module + include it in main bundle
etpinard db3d18b
fix typo in getComponentMethod call
etpinard 05b2f96
skip over calendar attribute in findArrayAttributes
etpinard 61ecd42
generalise plot schema handling of component attributes
etpinard 68af287
add schema attributes in calendars module
etpinard cb2c54b
move calendar defaults after early return
etpinard bc457a9
Merge pull request #1230 from plotly/world-cals-component
etpinard 1444f55
use only the calendars we need from 'world-calendars'
etpinard 08f18ca
Merge pull request #1237 from plotly/world-cals-trimmed
etpinard dcddcee
support chinese calendar
alexcjohnson bbb76a4
Merge branch 'master' into world-cals
alexcjohnson 8d8e936
fix some tests for chinese, and robustify dateTime2ms
alexcjohnson 0e05f95
update baseline image with chinese calendar
alexcjohnson 509f287
perf: parseInt for string-leading int extraction
alexcjohnson 7bd501f
prevent non-gregorian month/year todate range selectors
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because of the extra args to the axis conversion functions, statements like
ax.range.map(ax.r2l)
would behave... strangely to say the least. This was actually already true for log axes, but it didn't seem to have bitten us yet. This helper fixes that and lets you pass the extra (constant) args straight through. Not super excited about its name, but I wanted to make sure people didn't use it in place of built-in map without understanding it first, that's why I didn't just call itlib.map
.