World calendars #1220
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| var isNumeric = require('fast-isnumeric'); | ||
|
|
||
| var Lib = require('@src/lib'); | ||
| var calComponent = require('@src/components/calendars'); | ||
|
|
||
| // use only the parts of world-calendars that we've imported for our tests | ||
| var calendars = require('@src/components/calendars/calendars'); | ||
|
|
||
| describe('dates', function() { | ||
| 'use strict'; | ||
|
|
@@ -240,6 +245,7 @@ describe('dates', function() { | |
| [ | ||
| [undefined, '1970-01-01'], | ||
| ['gregorian', '1970-01-01'], | ||
| ['chinese', '1969-11-24'], | ||
| ['coptic', '1686-04-23'], | ||
| ['discworld', '1798-12-27'], | ||
| ['ethiopian', '1962-04-23'], | ||
|
|
@@ -284,6 +290,55 @@ describe('dates', function() { | |
| expect(Lib.dateTime2ms(expected_lastinstant, calendar)).toBe(lastInstant, calendar); | ||
| }); | ||
| }); | ||
|
|
||
| it('should contain canonical ticks sundays, ranges for all calendars', function() { | ||
|
|
||
| var calList = Object.keys(calendars.calendars).filter(function(v) { | ||
| return v !== 'gregorian'; | ||
| }); | ||
|
|
||
| var canonicalTick = calComponent.CANONICAL_TICK, | ||
| canonicalSunday = calComponent.CANONICAL_SUNDAY, | ||
| dfltRange = calComponent.DFLTRANGE; | ||
| expect(Object.keys(canonicalTick).length).toBe(calList.length); | ||
| expect(Object.keys(canonicalSunday).length).toBe(calList.length); | ||
| expect(Object.keys(dfltRange).length).toBe(calList.length); | ||
|
|
||
| calList.forEach(function(calendar) { | ||
| expect(Lib.dateTime2ms(canonicalTick[calendar], calendar)).toBeDefined(calendar); | ||
| var sunday = Lib.dateTime2ms(canonicalSunday[calendar], calendar); | ||
| // convert back implicitly with gregorian calendar | ||
| expect(Lib.formatDate(sunday, '%A')).toBe('Sunday', calendar); | ||
|
|
||
| expect(Lib.dateTime2ms(dfltRange[calendar][0], calendar)).toBeDefined(calendar); | ||
| expect(Lib.dateTime2ms(dfltRange[calendar][1], calendar)).toBeDefined(calendar); | ||
| }); | ||
| }); | ||
|
|
||
| it('should handle Chinese intercalary months correctly', function() { | ||
| var intercalaryDates = [ | ||
| '1995-08i-01', | ||
| '1995-08i-29', | ||
| '1984-10i-15', | ||
| '2023-02i-29' | ||
| ]; | ||
| intercalaryDates.forEach(function(v) { | ||
| var ms = Lib.dateTime2ms(v, 'chinese'); | ||
| expect(Lib.ms2DateTime(ms, 0, 'chinese')).toBe(v); | ||
|
|
||
| // should also work without leading zeros | ||
| var vShort = v.replace(/-0/g, '-'); | ||
| expect(Lib.dateTime2ms(vShort, 'chinese')).toBe(ms, vShort); | ||
| }); | ||
|
|
||
| var badIntercalaryDates = [ | ||
| '1995-07i-01', | ||
| '1995-08i-30', | ||
| '1995-09i-01' | ||
| ]; | ||
| badIntercalaryDates.forEach(function(v) { | ||
| expect(Lib.dateTime2ms(v, 'chinese')).toBeUndefined(v); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('cleanDate', function() { | ||
|
|
@@ -341,6 +396,51 @@ describe('dates', function() { | |
| }); | ||
| }); | ||
|
|
||
| describe('incrementMonth', function() { | ||
| it('should include Chinese intercalary months', function() { | ||
|
There was a problem hiding this comment. I should add a similar tests to world-calendars |
||
| var start = '1995-06-01'; | ||
| var expected = [ | ||
| '1995-07-01', | ||
| '1995-08-01', | ||
| '1995-08i-01', | ||
| '1995-09-01', | ||
| '1995-10-01', | ||
| '1995-11-01', | ||
| '1995-12-01', | ||
| '1996-01-01' | ||
| ]; | ||
| var tick = Lib.dateTime2ms(start, 'chinese'); | ||
| expected.forEach(function(v) { | ||
| tick = Lib.incrementMonth(tick, 1, 'chinese'); | ||
| expect(tick).toBe(Lib.dateTime2ms(v, 'chinese'), v); | ||
| }); | ||
| }); | ||
|
|
||
| it('should increment years even over leap years', function() { | ||
| var start = '1995-06-01'; | ||
| var expected = [ | ||
| '1996-06-01', | ||
| '1997-06-01', | ||
| '1998-06-01', | ||
| '1999-06-01', | ||
| '2000-06-01', | ||
| '2001-06-01', | ||
| '2002-06-01', | ||
| '2003-06-01', | ||
| '2004-06-01', | ||
| '2005-06-01', | ||
| '2006-06-01', | ||
| '2007-06-01', | ||
| '2008-06-01' | ||
| ]; | ||
| var tick = Lib.dateTime2ms(start, 'chinese'); | ||
| expected.forEach(function(v) { | ||
| tick = Lib.incrementMonth(tick, 12, 'chinese'); | ||
|
There was a problem hiding this comment. 12? I guess There was a problem hiding this comment. yes exactly: #1220 (comment) |
||
| expect(tick).toBe(Lib.dateTime2ms(v, 'chinese'), v); | ||
| }); | ||
| }); | ||
| }); | ||
|
|
||
| describe('isJSDate', function() { | ||
| it('should return true for any Date object but not the equivalent numbers', function() { | ||
| [ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻