Skip to content

Fix mapbox image tests #1213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 1, 2016
Merged

Fix mapbox image tests #1213

merged 3 commits into from
Dec 1, 2016

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Dec 1, 2016

npm run test-image -- mapbox_* was broken in the latest imagetest image, this PR fixes it.

... when generating image, instead of hanging with no logs.
- the latest imagetest image set MAPBOX_ACCESS_TOKEN in
  the image server main which makes the Plotly.setPlotConfig call
  in <script set_plot_config.js> irrelevant.
- replace this by a sed call which injects MAPBOX_ACCESS_TOKEN
  into the image server main
@etpinard etpinard merged commit c25d57b into master Dec 1, 2016
@etpinard etpinard deleted the fix-mapbox-image-test branch December 1, 2016 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant