Skip to content

remove commented out code about 3d pie chart attributes #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2016
Merged

remove commented out code about 3d pie chart attributes #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 0 additions & 34 deletions src/traces/pie/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,40 +160,6 @@ module.exports = {
].join(' ')
}
},
// 3D attributes commented out until I finish them in a later PR
// tilt: {
// // degrees to tilt the pie back from straight on
// valType: 'number',
// min: 0,
// max: 90,
// dflt: 0
// },
// tiltaxis: {
// // degrees away from straight up to tilt the pie
// // only has an effect if tilt is nonzero
// valType: 'number',
// min: -360,
// max: 360,
// dflt: 0
// },
// depth: {
// // "3D" size, as a fraction of radius
// // only has an effect if tilt is nonzero
// valType: 'number',
// min: 0,
// max: 10,
// dflt: 0.5
// },
// shading: {
// // how much darker to make the sides than the top,
// // with a 3D effect. We could of course get all
// // fancy with lighting effects, but maybe this is
// // sufficient.
// valType: 'number',
// min: 0,
// max: 1,
// dflt: 0.2
// },
hole: {
valType: 'number',
role: 'style',
Expand Down