Enforce casting requested frame names to strings #1124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Nov 9, 2016
| @@ -1815,6 +1818,9 @@ plots.transition = function(gd, data, layout, traces, frameOpts, transitionOpts) | |||
| } | |||
|
|
|||
| function interruptPreviousTransitions() { | |||
| // Fail-safe against purged plot: | |||
There was a problem hiding this comment.
thanks for the comment here.
There was a problem hiding this comment.
This could go elsewhere so that no failsafe is needed, but it's a trivially inexpensive one-liner, so I think it's a good idea.
etpinard
reviewed
Nov 9, 2016
| beforeEach(function(done) { | ||
| gd = createGraphDiv(); | ||
| mockCopy = Lib.extendDeep({}, mock); | ||
| Plotly.plot(gd, mockCopy.data, mockCopy.layout).then(function() { |
There was a problem hiding this comment.
why use the two-argument signature here? 😄
There was a problem hiding this comment.
historical reasons!
|
very nice 💃 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frame names were successfully cast to strings, but requested frames via
Plotly.animatewere not. This PR fixes it and adds some tests. It also adds one small fail-safe against callbacks that execute after a plot has been purged.See: #1035