Skip to content

Fix gl2d axis title positioning #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2016
Merged

Fix gl2d axis title positioning #1067

merged 2 commits into from
Oct 24, 2016

Conversation

etpinard
Copy link
Contributor

fixes #198

Now that we have image test support for gl2d plots, might as well fix a long-standing bug 🎉

This PR relies on work done in:

@etpinard etpinard added bug something broken status: in progress labels Oct 21, 2016
@etpinard etpinard added this to the v1.19.0 milestone Oct 21, 2016
@etpinard
Copy link
Contributor Author

The new baselines from 6241fe1 were generated locally after npm linking patch in gl-plot2d and text-cache. They fill failed on CircleCI until the aforementioned patches are reviewed and published.

@etpinard etpinard merged commit 99826a2 into master Oct 24, 2016
@etpinard etpinard deleted the gl2d-axis-title-bug branch October 24, 2016 15:45
This was referenced Oct 24, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.19.0
Development

Successfully merging this pull request may close these issues.

Uncentered Scattergl yaxis
1 participant
@etpinard