Fix expect(new Array(1)).toEqual([undefined]) failures on *some* platforms #1048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rreusser
commented
Oct 17, 2016
| var i; | ||
| if(Array.isArray(x)) { | ||
| for(i = 0; i < x.length; i++) { | ||
| x[i] = x[i]; |
etpinard
reviewed
Oct 17, 2016
| }); | ||
|
|
||
| it('expands bracketed array notation with further nesting', function() { | ||
| var input = {'marker[1].size.magnitude': 8}; | ||
| var expected = {marker: [undefined, {size: {magnitude: 8}}]}; | ||
| var computed = Lib.expandObjectPaths(input); | ||
| expect(computed).toEqual(expected); | ||
| expectLooseDeepEqual(computed, expected); |
There was a problem hiding this comment.
Instead of that custom assert routine, why not just have to expect statements:
expect(computed.marker[0]).toBeUndefined();
expect(computed.marker[1]).toEqual({ size: { magnitude: 8 } });There was a problem hiding this comment.
I can move the function inside this block, but ideally wanted to avoid manually digging through the objects.
There was a problem hiding this comment.
Yeah that make sense.
What about moving your new expectLooseDeepEqual to assets/custom_matchers.js ?
|
@etpinard added |
|
💃 once test pass! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test adds a helper function to the lib test in order to loosen the comparison to what we actually care about, which is array access, not array content.
Gross.