Add note directing to pretest #1040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah good point, |
etpinard
suggested changes
Oct 14, 2016
| @@ -1,6 +1,6 @@ | |||
| # plotly.js image testing | |||
|
|
|||
| Test plotly.js with Plotly's image testing docker container. | |||
| Test plotly.js with Plotly's image testing docker container. Before starting, don't forget to [set up your testing environment with `npm run pretest`](https://github.com/plotly/plotly.js/blob/master/CONTRIBUTING.md#development). | |||
There was a problem hiding this comment.
I would put this new line under
as pretest has nothing to do with docker.
There was a problem hiding this comment.
Great, that's what I was wondering. So is correct usage right below the 'IMPORTANT' section as a "before you do any of these other things" command?
There was a problem hiding this comment.
I'd vote for putting it above the IMPORTANT.
Mentioning pretest should be a reminder as opposed to an important comment.
etpinard
approved these changes
Oct 14, 2016
|
Nicely done 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to the first line of the image test instructions:
I could make this Step 0. Or Step 1. Or Step 1.5. Glad to amend, but I think it's worth mentioning on this page since the tests don't work without it. Wasn't strictly sure where in the sequence it had to go.