Fix Firefox toImage failures #104
Conversation
| @@ -114,7 +114,7 @@ module.exports = function toSVG(gd, format) { | |||
| // Is this an IE thing? Any other attributes or style elements that can have quotes in them? | |||
| // TODO: this looks like a noop right now - what happened to it? | |||
| var ff = txt.style('font-family'); | |||
| if(ff && ff.indexOf('"') !== -1) txt.style('font-family', ff.replace(/"/g, '"')); | |||
| if(ff && ff.indexOf('"') !== -1) txt.style('font-family', ff.replace(/"/g, '\\\'')); | |||
There was a problem hiding this comment.
@alexcjohnson could you comment of the comment above this line?
This patch makes toImage work in FF 42.
There was a problem hiding this comment.
lets put a lot of comments here . I would link the codepen example and bug issue and even this PR # in the code. In one year when something else goes wrong here we will be glad of it :)
There was a problem hiding this comment.
I'm thinking this was needed for when we passed svg to the back end for image gen... Then we turned it to a noop when we started doing this same fix on the back end... Then it became moot when we started passing json.
|
This codepen was pretty helpful in figuring out this bug: http://codepen.io/etpinard/pen/bEdQWK |
|
includes a codepen :) double 👯 ! |
|
FYI @cpsievert this might fix the Rstudio png bug |
@alexcjohnson @bpostlethwaite @mdtusz @cldougl
One nasty bug.