Skip to content

Fix badly chosen default positioning for sliders #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 12, 2016
Merged

Conversation

rreusser
Copy link
Contributor

This is a trivial PR that fixes poorly chosen defaults for sliders. It should look nice by default, not by configuration. This PR sets:

{
  x: 0,
  y: 0,
  xanchor: 'left',
  yanchor: 'top',
  pad: {t: 20}
}

In many cases, this will hopefully just make it unnecessary to do much with the appearance. The result for an otherwise unstyled slider now looks like:

screen shot 2016-10-11 at 17 36 31

@rreusser rreusser changed the title Fix a badly set default x value for sliders Fix a badly chosen default positioning for sliders Oct 11, 2016
@rreusser rreusser changed the title Fix a badly chosen default positioning for sliders Fix badly chosen default positioning for sliders Oct 11, 2016
@rreusser rreusser added bug something broken status: reviewable labels Oct 11, 2016
@etpinard
Copy link
Contributor

thanks 💃

@etpinard etpinard added this to the v1.18.0 milestone Oct 12, 2016
@rreusser rreusser merged commit 0109c9b into master Oct 12, 2016
@rreusser rreusser deleted the fix-slider-x-default branch October 12, 2016 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants