-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Common interface to interpret and execute API methods #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f2d268d
Start implementing command execution wrapper
rreusser 65f618d
Write failing tests for binding computation
rreusser 7ef0404
Add a lot of tests for binding computation
rreusser edb6773
Implement animate and update binding computation
rreusser f50fcaa
Switch return format of bindings to structured output
rreusser 60dd634
Merge remote-tracking branch 'origin/master' into lib-commands
rreusser 4bc8387
Command to decide when bindings are simple
rreusser 93b8253
First working version of bindings
rreusser 43dc3d4
Change the method name
rreusser 65d24f3
Fix updatemenus bindings
rreusser d2696e7
Hook up animations to sliders via bindings
rreusser 7db7f03
Clean up slider positioning code
rreusser 57fcf96
Add mock for bindings
rreusser 7db5f1f
emove custom plotmodified event
rreusser 26ad1ff
Add binding baseline image
rreusser 986b4dc
Fix irritating self-interaction when dragging slider
rreusser 20ac69f
Fix lint issue
rreusser f993ed7
Change failure modes for command API
rreusser 99d7c8e
Ugh linter again
rreusser f8c0094
Improve robustness of command bindings
rreusser 6abec15
Test more behavior of bindings
rreusser 5df94a7
Fix linter issue
rreusser d35ee35
Remove binding test file
rreusser a554cad
Add equivalent command API test for udpatemenus
rreusser e5a80ee
DRY up binding change check
rreusser 45717b1
Add note about test failure
rreusser 52de9e4
createCommandObserver --> manageCommandObserver
rreusser 0c40b02
Remove hard-coded updatemenus active default
rreusser df2d5bb
Revert updatemenus initialization and fix sliders initialization
rreusser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !