Skip to content

Heatmap crashes with d3 errors when the x and y axis label arrays only contain a single string #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wobenshain opened this issue Jul 26, 2016 · 1 comment
Closed

Heatmap crashes with d3 errors when the x and y axis label arrays only contain a single string #782

wobenshain opened this issue Jul 26, 2016 · 1 comment
Labels
bug something broken community community contribution
Milestone
v1.16.0

Comments

@wobenshain
Copy link
Contributor

http://codepen.io/wobenshain/pen/XKYmGA

This appears to be an unintended consequence of the fix for Issue #605 which causes v0 to be set to a string instead of V0In or 0.

Relevant commit: b913a5b
@wobenshain wobenshain changed the title Heatmap crashes with d3 errors when plotting when the x and y axis label arrays only contain a single string Heatmap crashes with d3 errors when the x and y axis label arrays only contain a single string Jul 26, 2016
@etpinard etpinard added bug something broken community community contribution and removed community community contribution labels Jul 28, 2016
@etpinard etpinard added this to the v1.16.0 milestone Jul 28, 2016
@etpinard etpinard added the community community contribution label Jul 28, 2016
etpinard added a commit that referenced this issue Aug 3, 2016
@etpinard
Merge pull request #783 from wobenshain/master
e8446b1 
Proposed fix to Issue #782
@etpinard
Copy link
Contributor

etpinard commented Aug 3, 2016

fixed via #783

@etpinard etpinard closed this as completed Aug 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken community community contribution
Projects
None yet
Milestone
v1.16.0
Development

No branches or pull requests
2 participants
@etpinard @wobenshain