Skip to content

Link text with query params does not work #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
etpinard opened this issue Jun 14, 2016 · 0 comments · Fixed by #736
Closed

Link text with query params does not work #642

etpinard opened this issue Jun 14, 2016 · 0 comments · Fixed by #736
Assignees
@etpinard
Labels
bug something broken

Comments

@etpinard
Copy link
Contributor

See http://codepen.io/etpinard/pen/pbyYQe

First reported http://community.plot.ly/t/cant-display-chart-with-href-contain-character/1284
@etpinard etpinard added the bug something broken label Jun 14, 2016
@etpinard etpinard self-assigned this Jul 8, 2016
etpinard added a commit that referenced this issue Jul 11, 2016
@etpinard
lib: handle '=' and '&' in anchor href
d58d3be 
- fixes #642
- strip only the leading '='
- replace & with '&' to make DOMParser happy
- wrap resulting href in ""
@etpinard etpinard mentioned this issue Jul 11, 2016
Merged
nielsenb-jf pushed a commit to nielsenb-jf/plotly.js that referenced this issue Jul 20, 2016
@etpinard @nielsenb-jf
lib: handle '=' and '&' in anchor href
2f344a0 
- fixes plotly#642
- strip only the leading '='
- replace & with '&' to make DOMParser happy
- wrap resulting href in ""
etpinard added a commit that referenced this issue Jul 29, 2016
@etpinard
lib: handle '=' and '&' in anchor href
0a1526d 
- fixes #642
- strip only the leading '='
- replace & with '&' to make DOMParser happy
- wrap resulting href in ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A few fixes in convertToTspans plotly/plotly.js
1 participant
@etpinard