Skip to content

[Bug] data[type=contour].line width documentation typo #4203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mafar opened this issue Sep 19, 2019 · 1 comment · Fixed by #4218
Closed

[Bug] data[type=contour].line width documentation typo #4203

mafar opened this issue Sep 19, 2019 · 1 comment · Fixed by #4218
Assignees
@etpinard

Comments

@mafar
Copy link
Contributor

mafar commented Sep 19, 2019

As per my tests , it seems that
for data[type=contour].line.width
default value is 0.5 instead of documented 2

https://plot.ly/javascript/reference/#contour-line-width
@mafar mafar changed the title [Bug] data[type=contour].line width documentation error [Bug] data[type=contour].line width documentation typo Sep 19, 2019
@etpinard
Copy link
Contributor

Thanks for reporting!

Here are the relevant lines in case someone would like to make a PR:

plotly.js/src/traces/contour/attributes.js

Lines 242 to 244 in 56f6983

width: extendFlat({}, scatterLineAttrs.width, {
editType: 'style+colorbars'
}),

plotly.js/src/traces/contour/style_defaults.js

Line 25 in 56f6983

coerce('line.width', 0.5);

@etpinard etpinard self-assigned this Sep 25, 2019
etpinard added a commit that referenced this issue Sep 25, 2019
@etpinard
fix #4203 - fix line.width attr declaration in *contour traces
0fb955c 
- unset dflt in contour `line.width`, explain default logic in description
- reuse contour `line` declaration in contourcarpet
- set hard dflt in histogram2dcontour `line.width` declaration,
  as histogram2dcontour trace only support level-style contours
  at the moment.
@etpinard etpinard mentioned this issue Sep 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix line.width attr declaration in *contour traces plotly/plotly.js
2 participants
@mafar @etpinard