Skip to content

Annotations are not getting clipped when panning #4141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
marfoldi opened this issue Aug 21, 2019 · 1 comment · Fixed by #4170
Closed

Annotations are not getting clipped when panning #4141

marfoldi opened this issue Aug 21, 2019 · 1 comment · Fixed by #4170
Assignees
@etpinard
Labels
bug something broken regression this used to work

Comments

@marfoldi
Copy link
Contributor

When panning the plot (using the 'Pan' tool or by dragging the axes) the annotations are not getting clipped until the action is finished.

https://codepen.io/plotly/pen/oXRjRJ

Under Windows on latest FF and Chrome.
@etpinard etpinard added the bug something broken label Aug 21, 2019
@etpinard
Copy link
Contributor

etpinard commented Sep 6, 2019

Looks like this is regression coming from a8fb653 part of v1.40.0

Things were working fine back in v1.39.0: https://codepen.io/etpinard/pen/NWKXEQL

@etpinard etpinard self-assigned this Sep 6, 2019
etpinard added a commit that referenced this issue Sep 6, 2019
@etpinard
fix #4141 - 🔪 wrong offscreen annotation during drag logic
2d39e2f
@etpinard etpinard mentioned this issue Sep 6, 2019
Merged
@archmoj archmoj added the regression this used to work label Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken regression this used to work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove off-screen annotations during drag plotly/plotly.js
3 participants
@marfoldi @etpinard @archmoj