Skip to content

3d grid lines are not anti-aliased in firefox #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taylorjacklespriggs opened this issue Aug 9, 2019 · 5 comments
Closed

3d grid lines are not anti-aliased in firefox #4117

taylorjacklespriggs opened this issue Aug 9, 2019 · 5 comments

Comments

@taylorjacklespriggs
Copy link

The grid lines in firefox do not appear to be antialiased which can be seen by the gaps and corners in the screenshot below. The grid lines in the chrome screenshot look totally fine.
I'm using firefox version 68.0.1 on Sierra.

Screenshots taken from the codepen example on the docs

Firefox

Screen Shot 2019-08-09 at 9 14 43 AM

Chrome

Screen Shot 2019-08-09 at 9 14 58 AM

specs
MacOS Sierra 10.12.6
MacBook Pro (15-inch, 2017)
Graphics

  • Radeon Pro 555 2048 MB
  • Intel HD Graphics 630 1536 MB
@archmoj
Copy link
Contributor

archmoj commented Aug 9, 2019

This may not be a plotly.js bug.
Please note that: although anti-aliasing is requested by the web-gl code on some hardware it may not be enabled e.g. Mac with FireFox.

cc: #2756
#2756 (comment)

Increasing plotGlPixelRatio may help improve the situation: see codepen.

@taylorjacklespriggs
Copy link
Author

Thanks @archmoj, the suggestion helped, I suppose it's because of the 9x supersampling?

@archmoj
Copy link
Contributor

archmoj commented Aug 9, 2019

If I recall the plotGlPixelRatio is by default 2. So that's the supersaturating diff is (9/4)x about 2x.

@taylorjacklespriggs
Copy link
Author

@archmoj here's a few screenshots with different plotGlPixelRatio settings (using your codepen example)
IMO Firefox with plotGlPixelRatio: 0 looks better than plotGlPixelRatio: 3, and Chrome with plotGlPixelRatio: 0 is clearly the most desirable.
Firefox does seem to blacklist MSAA on my hardware https://wiki.mozilla.org/Blocklisting/Blocked_Graphics_Drivers#On_Mac

Chrome with plotGlPixelRatio: 0

Screen Shot 2019-08-14 at 2 35 02 PM

Chrome with plotGlPixelRatio: 3

Screen Shot 2019-08-14 at 2 35 42 PM

Firefox with plotGlPixelRatio: 0

Screen Shot 2019-08-14 at 2 36 26 PM

Firefox with plotGlPixelRatio: 3

Screen Shot 2019-08-14 at 2 37 03 PM

@gvwilson
Copy link
Contributor

Hi - we are currently trying to tidy up Plotly's public repositories to help us focus our efforts on things that will help users most. Since this issue has been sitting for several years, I'm going to close it. If it's still a concern, we'd be grateful if you could open a new issue (with a short reproducible example if appropriate) so that we can add it to our backlog. Thanks for your help - @gvwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants