Skip to content

Clipped rotated tick labels with automargin #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wbrgss opened this issue Feb 25, 2019 · 0 comments · Fixed by #3605
Closed

Clipped rotated tick labels with automargin #3579

wbrgss opened this issue Feb 25, 2019 · 0 comments · Fixed by #3605
Assignees
@etpinard
Labels
bug something broken

Comments

@wbrgss
Copy link
Contributor

wbrgss commented Feb 25, 2019

Related: #2985

The automargin padding calculation in the above issue has been fixed (:bowing_man:); however, longer tick labels still appear to be significantly clipped on graph widths that render the labels on an angle:

image

Codepen (a fork of the one in the above issue)
@etpinard etpinard added the bug something broken label Feb 26, 2019
@etpinard etpinard self-assigned this Mar 1, 2019
etpinard added a commit that referenced this issue Mar 1, 2019
@etpinard
wip attempt at fixing #3579
31c3840
@etpinard etpinard mentioned this issue Mar 4, 2019
Closed
etpinard added a commit that referenced this issue Mar 4, 2019
@etpinard
fix #3579 - consider tick labels to go past plot area
6c7db5e 
... in axis automargin computations. Add two mocks to lock this down!
etpinard added a commit that referenced this issue Mar 4, 2019
@etpinard
improve axis automargin tests
1f6e711 
- start tests with margin:{l:0, t:0, r:0, b:0}
  to get more consistent result machine-to-machine
- add a few check to 🔒 #3579 even more
@etpinard etpinard mentioned this issue Mar 4, 2019
Merged
@wbrgss wbrgss mentioned this issue Nov 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etpinard etpinard

Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automargin edge cases plotly/plotly.js
2 participants
@etpinard @wbrgss