Skip to content

Colorscale attribute descriptions in cone traces are off #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonmmease opened this issue Jun 11, 2018 · 6 comments
Closed

Colorscale attribute descriptions in cone traces are off #2723

jonmmease opened this issue Jun 11, 2018 · 6 comments

Comments

@jonmmease
Copy link
Contributor

In trying out the new cone trace in plotly/plotly.py#942 I noticed that the color property for this trace type isn't included in the dist/plotly-schema.json file (at least for 1.38.2). If I understand correctly there should be a cone.color property alongside cone.colorscale, cone.cmin, etc.

Here's a screenshot of my editor with all of the property bodies collapsed.

screen shot 2018-06-11 at 3 13 12 pm

For context, I found this because the Cone Python class generated from the schema was missing a color property 🙂

@etpinard
Copy link
Contributor

No this is correct. There's no color attribute for cones yet. Cones are colored by their corresponding u/v/w norm and that's all we allow at the moment.

@jonmmease
Copy link
Contributor Author

Ok, that makes sense. Thanks for the info.

I guess the less critical issue is that the default descriptions on other color-related properties still refer to a color property.

e.g. The description of colorscale reads "Sets the colorscale and only has an effect if color is set to a numerical array. ..." cmin and cmax also have similar language.

Since these descriptions will now be included as Python docstrings it would be nice to get the "u/v/w norm" language in there at some point.

And the cone trace looks awesome BTW!

@etpinard etpinard changed the title Cone color property not included in plotly-schema.json Colorscale attribute descriptions in cone traces are off Jun 11, 2018
@etpinard
Copy link
Contributor

I guess the less critical issue is that the default descriptions on other color-related properties still refer to a color property.

Oops. Thanks for letting us know!

@jzthree
Copy link

jzthree commented Jul 27, 2018

Is it a future possibility to allow user setting color property in Cone? That will be very useful like it does in other plot types.

@CarlAndersson
Copy link

I agree with @jzthree that direct control of the color can be really useful in some cases.

@RinconFer
Copy link

Hi, It's been a long time since this issue was raised again, but I am using plotly to render UMAP embedding from scRNAseq where I use the cones direction and size to show the RNA velocity. I would like to be able to use the color variable to plot other variables (clustering, cell type, sample, latent time,...) Is there any way to change the color already? If it is still not available, is that option expected to be included soon?
Basically I would like to combine this go.Cone figure
image
With the colors in this scatter_3d
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants