Skip to content

Commit 9e3c533

Browse files
committed
fix #2723 - list correct 'color' attribute in cone,
... mesh3d, surface and streamtube attribute declarations.
1 parent d33fc45 commit 9e3c533

File tree

4 files changed

+29
-24
lines changed

4 files changed

+29
-24
lines changed

src/traces/cone/attributes.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
'use strict';
1010

11-
var colorAttrs = require('../../components/colorscale/color_attributes');
1211
var colorscaleAttrs = require('../../components/colorscale/attributes');
1312
var colorbarAttrs = require('../../components/colorbar/attributes');
1413
var mesh3dAttrs = require('../mesh3d/attributes');
@@ -161,11 +160,13 @@ var attrs = {
161160
}
162161
};
163162

164-
extendFlat(attrs, colorAttrs('', 'calc', true), {
165-
showscale: colorscaleAttrs.showscale,
163+
extendFlat(attrs, colorscaleAttrs('', {
164+
colorAttr: 'u/v/w norm',
165+
showScaleDflt: true,
166+
editTypeOverride: 'calc'
167+
}), {
166168
colorbar: colorbarAttrs
167169
});
168-
delete attrs.color;
169170

170171
var fromMesh3d = ['opacity', 'lightposition', 'lighting'];
171172

src/traces/mesh3d/attributes.js

+10-6
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,14 @@
88

99
'use strict';
1010

11-
var colorAttrs = require('../../components/colorscale/color_attributes');
1211
var colorscaleAttrs = require('../../components/colorscale/attributes');
1312
var colorbarAttrs = require('../../components/colorbar/attributes');
1413
var surfaceAtts = require('../surface/attributes');
1514
var baseAttrs = require('../../plots/attributes');
1615

1716
var extendFlat = require('../../lib/extend').extendFlat;
1817

19-
module.exports = extendFlat(colorAttrs('', 'calc', false), {
18+
module.exports = extendFlat({
2019
x: {
2120
valType: 'data_array',
2221
editType: 'calc+clearAxisTypes',
@@ -166,8 +165,16 @@ module.exports = extendFlat(colorAttrs('', 'calc', false), {
166165
'Overrides *color* and *vertexcolor*.'
167166
].join(' ')
168167
},
168+
},
169+
170+
colorscaleAttrs('', {
171+
colorAttr: '`intensity`',
172+
showScaleDflt: true,
173+
editTypeOverride: 'calc'
174+
}), {
175+
176+
colorbar: colorbarAttrs,
169177

170-
// Opacity
171178
opacity: surfaceAtts.opacity,
172179

173180
// Flat shaded mode
@@ -193,9 +200,6 @@ module.exports = extendFlat(colorAttrs('', 'calc', false), {
193200
editType: 'calc'
194201
},
195202

196-
showscale: colorscaleAttrs.showscale,
197-
colorbar: colorbarAttrs,
198-
199203
lightposition: {
200204
x: extendFlat({}, surfaceAtts.lightposition.x, {dflt: 1e5}),
201205
y: extendFlat({}, surfaceAtts.lightposition.y, {dflt: 1e5}),

src/traces/streamtube/attributes.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88

99
'use strict';
1010

11-
var colorAttrs = require('../../components/colorscale/color_attributes');
1211
var colorscaleAttrs = require('../../components/colorscale/attributes');
1312
var colorbarAttrs = require('../../components/colorbar/attributes');
1413
var mesh3dAttrs = require('../mesh3d/attributes');
@@ -134,11 +133,13 @@ var attrs = {
134133
}
135134
};
136135

137-
extendFlat(attrs, colorAttrs('', 'calc', true), {
138-
showscale: colorscaleAttrs.showscale,
136+
extendFlat(attrs, colorscaleAttrs('', {
137+
colorAttr: 'u/v/w norm',
138+
showScaleDflt: true,
139+
editTypeOverride: 'calc'
140+
}), {
139141
colorbar: colorbarAttrs
140142
});
141-
delete attrs.color;
142143

143144
var fromMesh3d = ['opacity', 'lightposition', 'lighting'];
144145
fromMesh3d.forEach(function(k) {

src/traces/surface/attributes.js

+9-10
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ function makeContourAttr(axLetter) {
9898
};
9999
}
100100

101-
var attrs = module.exports = overrideAll({
101+
var attrs = module.exports = overrideAll(extendFlat({
102102
z: {
103103
valType: 'data_array',
104104
description: 'Sets the z coordinates.'
@@ -131,15 +131,14 @@ var attrs = module.exports = overrideAll({
131131
'used for setting a color scale independent of `z`.'
132132
].join(' ')
133133
},
134+
},
134135

135-
cauto: colorscaleAttrs.zauto,
136-
cmin: colorscaleAttrs.zmin,
137-
cmax: colorscaleAttrs.zmax,
138-
colorscale: colorscaleAttrs.colorscale,
139-
autocolorscale: extendFlat({}, colorscaleAttrs.autocolorscale,
140-
{dflt: false}),
141-
reversescale: colorscaleAttrs.reversescale,
142-
showscale: colorscaleAttrs.showscale,
136+
colorscaleAttrs('', {
137+
colorAttr: 'z or surfacecolor',
138+
showScaleDflt: true,
139+
autoColorDflt: false,
140+
editTypeOverride: 'calc'
141+
}), {
143142
colorbar: colorbarAttrs,
144143

145144
contours: {
@@ -254,6 +253,6 @@ var attrs = module.exports = overrideAll({
254253
},
255254

256255
hoverinfo: extendFlat({}, baseAttrs.hoverinfo)
257-
}, 'calc', 'nested');
256+
}), 'calc', 'nested');
258257

259258
attrs.x.editType = attrs.y.editType = attrs.z.editType = 'calc+clearAxisTypes';

0 commit comments

Comments
 (0)