-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Webpack] Module not found: Error: Can't resolve 'vertx' in '/home/user/app/node_modules/plotly.js/dist' #2466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Exact same issue with |
Just to confirm: this is showing up as a warning, and compilation proceeds, right? |
@nicolaskruchten I am having the same issue and yes, it is logging as a |
But, to note, I am now getting too many WebGL contexts in the console, where as before I wasn't. Not sure if this is related, but it did pop up with the 1.35.1 and this warning. |
That shouldn't be related. @chiaramdelucia would you mind sharing a reproducible example? Thank you! |
@etpinard I didn't really think it would be, but thought I would note it JIC. As for reproducible code, here is a codepen. This isn't exactly what happens in my app, but it is similar. In the pen's console you'll see the following on the first button click, but not after that. In my app, which uploads a dataset, it prints the following on the third time a dataset is uploaded. |
Hmm. I can't replicate. Can anyone else try out @chiaramdelucia 's codepen? |
Oh, wow. Now I can't reproduce it either with that codepen. I'm sorry about that. I guess it must be something specific to application setup. Thanks for looking @etpinard. |
I'm actually experiencing the same issue -
I'm trying to test this in a development environment - we're using |
Since v1.35.x, I'am also get a huge warning. It is used in Angular (angular-cli) project:
|
The webpack issue has been confirmed. No need for anyone test it themselves. #2466 (comment) were referenring to another issue. Thanks. |
Yes, webpack presents it as a warning and is able to complete the compilation. |
The error is from the es6 promise shim. Discussed here #100 and here #305. I had to add new webpack.IgnorePlugin(/vertx/) to my plugins to squelch the warning. Other things mentioned in the two discussions did not work. I'm still on webpack 3.10 and started getting this when updating to plotly.js 1.35.2 a few days ago. |
experiencing the same issue during compile time. Application and Plotly components all work fine. For me it comes with another warning, which may or may not be related.
|
It is a prebuilt file. My recollection is that Uglify, which is smarter than webpack, was loading a module from es6 shim that was not transpiled, causing it to choke in release builds as soon as it encountered an es6 keyword such as let or const, or something like that. To mitigate this, react-plotly.js was tweaked to load the prebuilt file, which is all in es5. What bundler and version are you using? |
We're still hoping someone finds a fix from within plotly.js for this issue. Looks like that That said, that |
also related: #2400 |
I've updated https://github.com/plotly/plotly-webpack to document the fact that the |
This issue has been tagged with A community PR for this feature would certainly be welcome, but our experience is deeper features like this are difficult to complete without the Plotly maintainers leading the effort. Sponsorship range: $10k-$15k What Sponsorship includes:
Please include the link to this issue when contacting us to discuss. |
This might be fixed by #5358. |
Yes, @archmoj feel free to close this issue. |
Error with plotly.js 1.35.1 and webpack 3.11.0 when importing:
import Plotly from 'plotly.js/dist/plotly-with-meta'
The text was updated successfully, but these errors were encountered: