We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@alexcjohnson
Aggregations are scooped out of incoming transform here: https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L158
and we check the length here: https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L159
But later we check if it is defined at all: https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L166
Partial aggregation transforms are easily composed in a UI and sending a partially complete transform without aggregations defined results in:
Cannot read property 'length' of undefined TypeError: Cannot read property 'length' of undefined
on line https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L159
The text was updated successfully, but these errors were encountered:
missing aggregations array no longer throws - fix #2024
e555e0a
bpostlethwaite
Successfully merging a pull request may close this issue.
@alexcjohnson
Aggregations are scooped out of incoming transform here:
https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L158
and we check the length here:
https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L159
But later we check if it is defined at all:
https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L166
Partial aggregation transforms are easily composed in a UI and sending a partially complete transform without aggregations defined results in:
on line https://github.com/plotly/plotly.js/blob/master/src/transforms/aggregate.js#L159
The text was updated successfully, but these errors were encountered: