Skip to content

scattergl open markers require explicit line width #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexcjohnson opened this issue Jul 31, 2017 · 4 comments
Closed

scattergl open markers require explicit line width #1921

alexcjohnson opened this issue Jul 31, 2017 · 4 comments
Labels
bug something broken
Milestone

Comments

@alexcjohnson
Copy link
Collaborator

In regular scatter, you don't need to specify a line width to get default width 1 for open symbols:

Plotly.newPlot(gd,[{
  y: [1, 2, 3],
  marker: {symbol: 'circle-open', size: 20},
  type: 'scatter',
  mode: 'markers'
}], {width:400, height:400})

screen shot 2017-07-31 at 4 14 21 pm

But change this to type: 'scattergl' and the markers disappear until you put an explicit line: {width: 1} in marker.

Note that this is independent of the marker.line.width in gd._fullData, which is still 0 in the scatter example above. This means supplyDefaults doesn't need to care about marker.symbol, and importantly, if marker.symbol is an array, you can use closed symbols (with no line width) alongside open symbols (with default line width 1) without explicitly saying this is what you're doing.

cc @dfcreative @VeraZab

@alexcjohnson alexcjohnson added the bug something broken label Jul 31, 2017
@alexcjohnson alexcjohnson added this to the On-par gl2d milestone Jul 31, 2017
@etpinard
Copy link
Contributor

etpinard commented Jan 8, 2018

@dfcreative

Plotly.newPlot(gd,[{
  y: [1, 2, 3],
  marker: {symbol: 'circle-open', size: 20},
  type: 'scattergl',
  mode: 'markers'
}], {width:400, height:400})

leads to

image

off https://github.com/plotly/plotly.js/tree/rescatter-squashed-2018

Would you mind taking a look this before we release regl?

@dy
Copy link
Contributor

dy commented Jan 11, 2018

@etpinard @alexcjohnson thanks! Fixed by 320c4c9

@dy
Copy link
Contributor

dy commented Jan 16, 2018

Added mock in 7cefeab

etpinard pushed a commit that referenced this issue Jan 17, 2018
etpinard pushed a commit that referenced this issue Jan 17, 2018
etpinard pushed a commit that referenced this issue Jan 17, 2018
etpinard pushed a commit that referenced this issue Jan 17, 2018
@etpinard
Copy link
Contributor

closed by #2258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

3 participants