-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
scattergl open markers require explicit line width #1921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
something broken
Milestone
Comments
Plotly.newPlot(gd,[{
y: [1, 2, 3],
marker: {symbol: 'circle-open', size: 20},
type: 'scattergl',
mode: 'markers'
}], {width:400, height:400}) leads to off https://github.com/plotly/plotly.js/tree/rescatter-squashed-2018 Would you mind taking a look this before we release |
@etpinard @alexcjohnson thanks! Fixed by 320c4c9 |
Added mock in 7cefeab |
etpinard
pushed a commit
that referenced
this issue
Jan 17, 2018
etpinard
pushed a commit
that referenced
this issue
Jan 17, 2018
etpinard
pushed a commit
that referenced
this issue
Jan 17, 2018
etpinard
pushed a commit
that referenced
this issue
Jan 17, 2018
closed by #2258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In regular scatter, you don't need to specify a line width to get default width 1 for open symbols:
But change this to
type: 'scattergl'
and the markers disappear until you put an explicitline: {width: 1}
inmarker
.Note that this is independent of the
marker.line.width
ingd._fullData
, which is still0
in thescatter
example above. This meanssupplyDefaults
doesn't need to care aboutmarker.symbol
, and importantly, ifmarker.symbol
is an array, you can use closed symbols (with no line width) alongside open symbols (with default line width 1) without explicitly saying this is what you're doing.cc @dfcreative @VeraZab
The text was updated successfully, but these errors were encountered: