Skip to content

Hover Info Test passing despite not calling Fx.hover properly #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rpaskowitz opened this issue Apr 10, 2017 · 0 comments
Closed

Hover Info Test passing despite not calling Fx.hover properly #1575

rpaskowitz opened this issue Apr 10, 2017 · 0 comments

Comments

@rpaskowitz
Copy link
Contributor

In hover_label_test.js#L20 the tests there have evt.clientX and evt.clientY, but graph_interact.js#L417 means that if evt.target is not set, then xpx and ypx will be used, and since they are unset, half the length of the axis is used. Since clientX and clientY were meant to be set to half of the graph anyways, it winds up being the same thing, but for different reasons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rpaskowitz @etpinard