Skip to content

Commit edc2710

Browse files
committed
lint passes
(cherry picked from commit 785012a)
1 parent ade3086 commit edc2710

File tree

11 files changed

+57
-57
lines changed

11 files changed

+57
-57
lines changed

lib/parcoords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/attributes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/base_plot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/calc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/colorbar.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/lines.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the

src/traces/parcoords/parcoords.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the
@@ -379,7 +379,7 @@ module.exports = function(root, styledData, layout, callbacks) {
379379
.each(function(d) {
380380
var wantedTickCount = d.model.height / d.model.tickDistance;
381381
var scale = d.domainScale;
382-
var dom = scale.domain();
382+
var sdom = scale.domain();
383383
var texts = d.ticktext;
384384
d3.select(this)
385385
.call(d3.svg.axis()
@@ -388,9 +388,8 @@ module.exports = function(root, styledData, layout, callbacks) {
388388
.outerTickSize(2)
389389
.ticks(wantedTickCount, '3s') // works for continuous scales only...
390390
.tickValues(d.ordinal ? // and this works for ordinal scales
391-
dom
392-
.filter(function(d, i) {return !(i % Math.round((dom.length / wantedTickCount)));})
393-
.map(function(d, i) {return texts && texts[i] || d}):
391+
sdom.filter(function(d, i) {return !(i % Math.round((sdom.length / wantedTickCount)));})
392+
.map(function(d, i) {return texts && texts[i] || d;}) :
394393
null)
395394
.scale(scale));
396395
});

src/traces/parcoords/plot.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Copyright 2012-2016, Plotly, Inc.
2+
* Copyright 2012-2017, Plotly, Inc.
33
* All rights reserved.
44
*
55
* This source code is licensed under the MIT license found in the
@@ -25,13 +25,14 @@ module.exports = function plot(gd, cdparcoords) {
2525
var range = value.changedDimension.domainFilter;
2626
var modelIndex = value.changedDimension.modelIndex;
2727
var i = value.changedDimension.index;
28+
var newData;
2829

2930
if(restyleStyle === 'deepProp') {
30-
Plotly.restyle(gd, 'dimensions[' + i + '].constraintrange[0]', range[0]).then(function () {
31+
Plotly.restyle(gd, 'dimensions[' + i + '].constraintrange[0]', range[0]).then(function() {
3132
Plotly.restyle(gd, 'dimensions[' + i + '].constraintrange[1]', range[1]);
3233
});
3334
} else if(restyleStyle === 'object') {
34-
var newData = Lib.extendDeep(gd.data)[modelIndex];
35+
newData = Lib.extendDeep(gd.data)[modelIndex];
3536
newData.dimensions[i].constraintrange = range.slice();
3637
Plotly.restyle(gd, [[newData]], modelIndex);
3738
} else if(restyleStyle === 'replot') {

test/jasmine/tests/parcoords_test.js

Lines changed: 41 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)