Skip to content

Commit ade3086

Browse files
committed
clearing up dimensions vs initialDims scope
(cherry picked from commit 134dc58)
1 parent fff904f commit ade3086

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/traces/parcoords/lines.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -147,18 +147,18 @@ function makeAttributes(sampleCount, points) {
147147
return attributes;
148148
}
149149

150-
module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, dimensions, unitToColor, context) {
150+
module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, initialDimensions, unitToColor, context) {
151151

152152
var renderState = {
153153
currentRafs: {},
154154
drawCompleted: true,
155155
clearOnly: false
156156
};
157157

158-
var initialDims = dimensions.slice();
158+
var initialDims = initialDimensions.slice();
159159

160-
var dimensionCount = dimensions.length;
161-
var sampleCount = dimensions.reduce(function(p, n) {return Math.min(p, n.values.length);}, dimensions[0].values.length);
160+
var dimensionCount = initialDims.length;
161+
var sampleCount = initialDims.reduce(function(p, n) {return Math.min(p, n.values.length);}, initialDims[0].values.length);
162162

163163
var focusAlphaBlending = context || lines.focusalphablending;
164164

@@ -169,7 +169,7 @@ module.exports = function(canvasGL, lines, canvasWidth, canvasHeight, dimensions
169169

170170
var panelCount = dimensionCount - 1;
171171

172-
var points = makePoints(sampleCount, dimensionCount, dimensions, color);
172+
var points = makePoints(sampleCount, dimensionCount, initialDims, color);
173173
var attributes = makeAttributes(sampleCount, points);
174174

175175
var regl = createREGL({

0 commit comments

Comments
 (0)