Skip to content

Commit e350dd0

Browse files
committed
no need to provide extra link to template - should provide name
1 parent 964fd6a commit e350dd0

File tree

4 files changed

+3
-3
lines changed

4 files changed

+3
-3
lines changed

src/plots/array_container_defaults.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ module.exports = function handleArrayContainerDefaults(parentObjIn, parentObjOut
4848

4949
var previousContOut = parentObjOut[name];
5050

51-
var contIn = Lib.isArrayOrTypedArray(parentObjIn[name]) ? parentObjIn[name] : (opts.fromTemplate || []);
51+
var contIn = Lib.isArrayOrTypedArray(parentObjIn[name]) ? parentObjIn[name] : [];
5252
var contOut = parentObjOut[name] = [];
5353
var templater = Template.arrayTemplater(parentObjOut, name, inclusionAttr);
5454
var i, itemOut;

src/plots/cartesian/axis_defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,6 @@ module.exports = function handleAxisDefaults(containerIn, containerOut, coerce,
130130

131131
if(Array.isArray(rangebreaks) && rangebreaks.length) {
132132
handleArrayContainerDefaults(containerIn, containerOut, {
133-
fromTemplate: fromTemplate,
134133
name: 'rangebreaks',
135134
inclusionAttr: 'enabled',
136135
handleItemDefaults: rangebreaksDefaults

src/plots/cartesian/tick_label_defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ function handleOtherDefaults(containerIn, containerOut, coerce, axType, options)
6464

6565
if(Array.isArray(tickformatStops) && tickformatStops.length) {
6666
handleArrayContainerDefaults(containerIn, containerOut, {
67-
fromTemplate: fromTemplate,
6867
name: 'tickformatstops',
6968
inclusionAttr: 'enabled',
7069
handleItemDefaults: tickformatstopDefaults

test/jasmine/tests/axes_test.js

+2
Original file line numberDiff line numberDiff line change
@@ -5433,9 +5433,11 @@ describe('Test template:', function() {
54335433
xaxis: {
54345434
type: 'date',
54355435
rangebreaks: [{
5436+
name: 'name1', // N.B. should provide name
54365437
bounds: ['sat', 'mon']
54375438
}],
54385439
tickformatstops: [{
5440+
name: 'name2', // N.B. should provide name
54395441
enabled: true,
54405442
dtickrange: [1000, 60000],
54415443
value: '%H:%M:%S s'

0 commit comments

Comments
 (0)