Skip to content

Commit 964fd6a

Browse files
committed
Revert "set various layout components via template"
This reverts commit 96e3590.
1 parent 0e0049d commit 964fd6a

File tree

9 files changed

+4
-15
lines changed

9 files changed

+4
-15
lines changed

src/components/annotations/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ var attributes = require('./attributes');
1919

2020
module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) {
2121
handleArrayContainerDefaults(layoutIn, layoutOut, {
22-
fromTemplate: (layoutOut._template || {}).annotations,
2322
name: 'annotations',
2423
handleItemDefaults: handleAnnotationDefaults
2524
});

src/components/annotations3d/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ var attributes = require('./attributes');
1616

1717
module.exports = function handleDefaults(sceneLayoutIn, sceneLayoutOut, opts) {
1818
handleArrayContainerDefaults(sceneLayoutIn, sceneLayoutOut, {
19-
fromTemplate: (sceneLayoutOut._template || {}).annotations,
2019
name: 'annotations',
2120
handleItemDefaults: handleAnnotationDefaults,
2221
fullLayout: opts.fullLayout

src/components/grid/index.js

+4-5
Original file line numberDiff line numberDiff line change
@@ -177,12 +177,11 @@ function getAxes(layout, grid, axLetter) {
177177
// the shape of the grid - this needs to be done BEFORE supplyDataDefaults
178178
// so that non-subplot traces can place themselves in the grid
179179
function sizeDefaults(layoutIn, layoutOut) {
180-
var gridIn = layoutIn.grid || ((layoutIn.template || {}).layout || {}).grid;
181-
var xAxes = getAxes(layoutOut, gridIn || {}, 'x');
182-
var yAxes = getAxes(layoutOut, gridIn || {}, 'y');
180+
var gridIn = layoutIn.grid || {};
181+
var xAxes = getAxes(layoutOut, gridIn, 'x');
182+
var yAxes = getAxes(layoutOut, gridIn, 'y');
183183

184-
if(!gridIn && !xAxes && !yAxes) return;
185-
if(!gridIn) gridIn = {};
184+
if(!layoutIn.grid && !xAxes && !yAxes) return;
186185

187186
var hasSubplotGrid = Array.isArray(gridIn.subplots) && Array.isArray(gridIn.subplots[0]);
188187
var hasXaxes = Array.isArray(xAxes);

src/components/images/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ var name = 'images';
1717

1818
module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) {
1919
var opts = {
20-
fromTemplate: (layoutOut._template || {}).images,
2120
name: name,
2221
handleItemDefaults: imageDefaults
2322
};

src/components/rangeselector/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ module.exports = function handleDefaults(containerIn, containerOut, layout, coun
2626
}
2727

2828
var buttons = handleArrayContainerDefaults(selectorIn, selectorOut, {
29-
fromTemplate: (selectorOut._template || {}).buttons,
3029
name: 'buttons',
3130
handleItemDefaults: buttonDefaults,
3231
calendar: calendar

src/components/shapes/defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ var helpers = require('./helpers');
1919

2020
module.exports = function supplyLayoutDefaults(layoutIn, layoutOut) {
2121
handleArrayContainerDefaults(layoutIn, layoutOut, {
22-
fromTemplate: (layoutOut._template || {}).shapes,
2322
name: 'shapes',
2423
handleItemDefaults: handleShapeDefaults
2524
});

src/components/sliders/defaults.js

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var stepAttrs = attributes.steps;
2020

2121
module.exports = function slidersDefaults(layoutIn, layoutOut) {
2222
handleArrayContainerDefaults(layoutIn, layoutOut, {
23-
fromTemplate: (layoutOut._template || {}).sliders,
2423
name: name,
2524
handleItemDefaults: sliderDefaults
2625
});
@@ -32,7 +31,6 @@ function sliderDefaults(sliderIn, sliderOut, layoutOut) {
3231
}
3332

3433
var steps = handleArrayContainerDefaults(sliderIn, sliderOut, {
35-
fromTemplate: (layoutOut._template || {}).steps,
3634
name: 'steps',
3735
handleItemDefaults: stepDefaults
3836
});

src/components/updatemenus/defaults.js

-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ var buttonAttrs = attributes.buttons;
2020

2121
module.exports = function updateMenusDefaults(layoutIn, layoutOut) {
2222
var opts = {
23-
fromTemplate: (layoutOut._template || {}).updatemenus,
2423
name: name,
2524
handleItemDefaults: menuDefaults
2625
};
@@ -34,7 +33,6 @@ function menuDefaults(menuIn, menuOut, layoutOut) {
3433
}
3534

3635
var buttons = handleArrayContainerDefaults(menuIn, menuOut, {
37-
fromTemplate: (layoutOut._template || {}).buttons,
3836
name: 'buttons',
3937
handleItemDefaults: buttonDefaults
4038
});

src/plots/mapbox/layout_defaults.js

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ function handleDefaults(containerIn, containerOut, coerce, opts) {
3535
coerce('pitch');
3636

3737
handleArrayContainerDefaults(containerIn, containerOut, {
38-
fromTemplate: (containerOut._template || {}).layers,
3938
name: 'layers',
4039
handleItemDefaults: handleLayerDefaults
4140
});

0 commit comments

Comments
 (0)