change dflt vwidth to 0;assign dPos for each trace

Author: Coding-with-Adam

src/traces/box/attributes.js

@@ -244,7 +244,6 @@ module.exports = {
         marker: scatterAttrs.unselected.marker,
         editType: 'style'
     },
-
     hoveron: {
         valType: 'flaglist',
         flags: ['boxes', 'points'],
@@ -267,4 +266,5 @@ module.exports = {
             'This overrides the normal width of the box traces.'
         ].join(' ')
     },
+
 };

src/traces/box/cross_trace_calc.js

@@ -48,11 +48,11 @@ function crossTraceCalc(gd, plotinfo) {
             }
         }
 
-        setPositionOffset('box', gd, boxList, posAxis, [minPad, maxPad], false);
+        setPositionOffset('box', gd, boxList, posAxis, [minPad, maxPad]);
     }
 }
 
-function setPositionOffset(traceType, gd, boxList, posAxis, pad, vwidth) {
+function setPositionOffset(traceType, gd, boxList, posAxis, pad) {
     var calcdata = gd.calcdata;
     var fullLayout = gd._fullLayout;
     var pointList = [];
@@ -77,11 +77,6 @@ function setPositionOffset(traceType, gd, boxList, posAxis, pad, vwidth) {
     var boxdv = Lib.distinctVals(pointList);
     var dPos = boxdv.minDiff / 2;
 
-    // override dPos if violin width given
-    if(vwidth) {
-        dPos = vwidth;
-    }
-
     // if there's no duplication of x points,
     // disable 'group' mode by setting counter to 1
     if(pointList.length === boxdv.vals.length) {
@@ -105,8 +100,15 @@ function setPositionOffset(traceType, gd, boxList, posAxis, pad, vwidth) {
 
     for(i = 0; i < boxList.length; i++) {
         calcTrace = calcdata[boxList[i]];
-        // set the width of all boxes
-        calcTrace[0].t.dPos = dPos;
+        // set the width of all boxes and
+        // override this width with
+        // trace.width if it exists
+        if(calcTrace[0].trace && calcTrace[0].trace.vwidth) {
+            calcTrace[0].t.dPos = calcTrace[0].trace.vwidth; 
+        } else {
+            calcTrace[0].t.dPos = dPos;   
+        }
+
         // link extremes to all boxes
         calcTrace[0].trace._extremes[posAxis._id] = extremes;
     }

src/traces/box/defaults.js

@@ -28,7 +28,13 @@ function supplyDefaults(traceIn, traceOut, defaultColor, layout) {
 
     coerce('whiskerwidth');
     coerce('boxmean');
-    coerce('vwidth');
+
+    // coerce('vwidth');
+    var vwidth = coerce('vwidth');
+    if(!vwidth) {
+        coerce('scalegroup', traceOut.name);
+        coerce('scalemode');
+    }
 
     var notched = coerce('notched', traceIn.notchwidth !== undefined);
     if(notched) coerce('notchwidth');

src/traces/violin/attributes.js

@@ -12,17 +12,6 @@ var boxAttrs = require('../box/attributes');
 var extendFlat = require('../../lib/extend').extendFlat;
 
 module.exports = {
-    vwidth: {
-        valType: 'number',
-        min: 0,
-        role: 'info',
-        dflt: 0,
-        editType: 'calc',
-        description: [
-            'Sets the width of the violins.',
-            'This overrides the normal width of the violins.'
-        ].join(' ')
-    },
     y: boxAttrs.y,
     x: boxAttrs.x,
     x0: boxAttrs.x0,
@@ -254,5 +243,17 @@ module.exports = {
             'Do the hover effects highlight individual violins',
             'or sample points or the kernel density estimate or any combination of them?'
         ].join(' ')
-    }
+    },
+
+    vwidth: {
+        valType: 'number',
+        min: 0,
+        role: 'info',
+        dflt: 0,
+        editType: 'calc',
+        description: [
+            'Sets the width of the violins.',
+            'This overrides the normal width of the violins.'
+        ].join(' ')
+    },
 };

src/traces/violin/cross_trace_calc.js

@@ -43,6 +43,6 @@ module.exports = function crossTraceCalc(gd, plotinfo) {
             }
         }
 
-        setPositionOffset('violin', gd, violinList, posAxis, [minPad, maxPad], trace.vwidth);
+        setPositionOffset('violin', gd, violinList, posAxis, [minPad, maxPad]);
     }
 };