Skip to content

Commit 81cdbe9

Browse files
some revision based on review comments
1 parent f76ca97 commit 81cdbe9

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

src/plots/plots.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2612,9 +2612,6 @@ function doCrossTraceCalc(gd) {
26122612
fullLayout[sp];
26132613

26142614
for(j = 0; j < methods.length; j++) {
2615-
console.log(methods);
2616-
console.log(methods[j])
2617-
console.log(methods[j].type)
26182615
methods[j](gd, spInfo, sp);
26192616
}
26202617
}

src/traces/box/attributes.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -260,11 +260,11 @@ module.exports = {
260260
valType: 'number',
261261
min: 0,
262262
role: 'info',
263-
dflt: false,
263+
dflt: 0,
264264
editType: 'calc',
265265
description: [
266-
'Sets the width of the violins.',
267-
'This overrides the normal width of the violins.'
266+
'Sets the width of the box.',
267+
'This overrides the normal width of the box traces.'
268268
].join(' ')
269269
},
270270
};

src/traces/box/cross_trace_calc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ function setPositionOffset(traceType, gd, boxList, posAxis, pad, vwidth) {
7878
var dPos = boxdv.minDiff / 2;
7979

8080
// override dPos if violin width given
81-
if (vwidth != false) {
81+
if(vwidth) {
8282
dPos = vwidth;
8383
}
8484

src/traces/violin/attributes.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ module.exports = {
1616
valType: 'number',
1717
min: 0,
1818
role: 'info',
19-
dflt: false,
19+
dflt: 0,
2020
editType: 'calc',
2121
description: [
2222
'Sets the width of the violins.',

src/traces/violin/defaults.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,13 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
2626
if(traceOut.visible === false) return;
2727

2828
coerce('bandwidth');
29-
coerce('scalegroup', traceOut.name);
30-
coerce('scalemode');
3129
coerce('side');
32-
coerce('vwidth');
30+
31+
var vwidth = coerce('vwidth');
32+
if(!vwidth) {
33+
coerce('scalegroup', traceOut.name);
34+
coerce('scalemode');
35+
}
3336

3437
var span = coerce('span');
3538
var spanmodeDflt;

0 commit comments

Comments
 (0)