Skip to content

Commit 2853691

Browse files
committed
fix missing catch and done in histogram2d tests
1 parent 2c0b913 commit 2853691

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

test/jasmine/tests/histogram2d_test.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ describe('Test histogram2d', function() {
263263
expect(gd.data[0].autobiny).toBeUndefined();
264264
}
265265

266-
it('handles autobin correctly on restyles', function() {
266+
it('handles autobin correctly on restyles', function(done) {
267267
var x1 = [
268268
1, 1, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 4,
269269
1, 1, 1, 1, 2, 2, 2, 2, 3, 3, 3, 3, 4, 4, 4, 4];
@@ -322,10 +322,12 @@ describe('Test histogram2d', function() {
322322
{start: -0.5, end: 59.5, size: 20},
323323
{start: -0.5, end: 59.5, size: 20},
324324
undefined, undefined);
325-
});
325+
})
326+
.catch(failTest)
327+
.then(done);
326328
});
327329

328-
it('respects explicit autobin: false as a one-time autobin', function() {
330+
it('respects explicit autobin: false as a one-time autobin', function(done) {
329331
// patched in for backward compat, but there aren't really
330332
// autobinx/autobiny attributes anymore
331333
var x1 = [
@@ -344,7 +346,9 @@ describe('Test histogram2d', function() {
344346
})
345347
.then(function() {
346348
_assert(binSpec, binSpec, binSpec, binSpec);
347-
});
349+
})
350+
.catch(failTest)
351+
.then(done);
348352
});
349353
});
350354
});

0 commit comments

Comments
 (0)