Skip to content

Commit 2c0b913

Browse files
committed
fix missing catch and done in funnelarea tests
1 parent 7f90732 commit 2c0b913

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

test/jasmine/tests/funnelarea_test.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -1153,7 +1153,7 @@ describe('Test event data of interactions on a funnelarea plot:', function() {
11531153
checkEventData(futureData);
11541154
});
11551155

1156-
it('should not contain pointNumber if aggregating', function() {
1156+
it('should not contain pointNumber if aggregating', function(done) {
11571157
var values = gd.data[0].values;
11581158
var labels = [];
11591159
for(var i = 0; i < values.length; i++) labels.push(i);
@@ -1168,7 +1168,9 @@ describe('Test event data of interactions on a funnelarea plot:', function() {
11681168
expect(futureData.points[0].pointNumber).toBeUndefined();
11691169
expect(futureData.points[0].i).toBeUndefined();
11701170
expect(futureData.points[0].pointNumbers).toEqual([0, 5]);
1171-
});
1171+
})
1172+
.catch(failTest)
1173+
.then(done);
11721174
});
11731175
});
11741176

@@ -1244,12 +1246,14 @@ describe('Test event data of interactions on a funnelarea plot:', function() {
12441246
expect(futureData).toBe(null);
12451247
});
12461248

1247-
it('should not emit a hover if hover is disabled', function() {
1249+
it('should not emit a hover if hover is disabled', function(done) {
12481250
Plotly.relayout(gd, 'hovermode', false)
12491251
.then(function() {
12501252
mouseEvent('mouseover', pointPos[0], pointPos[1]);
12511253
expect(futureData).toBe(null);
1252-
});
1254+
})
1255+
.catch(failTest)
1256+
.then(done);
12531257
});
12541258
});
12551259

0 commit comments

Comments
 (0)