Get event_data working on shiny modules

DESCRIPTION

@@ -44,7 +44,7 @@ Suggests:
     testthat,
     knitr,
     devtools,
-    shiny,
+    shiny (>= 0.13.2.9005),
     htmltools,
     curl,
     rmarkdown,
@@ -57,3 +57,5 @@ Suggests:
 LazyData: true
 VignetteBuilder: knitr
 RoxygenNote: 5.0.1
+Remotes:
+  rstudio/shiny

R/plotly.R

@@ -119,6 +119,7 @@ plot_ly <- function(data = data.frame(), ..., type = NULL,
   id <- new_id()
   # avoid weird naming clashes
   plotlyVisDat <- data
+
   p <- list(
     visdat = setNames(list(function() plotlyVisDat), id),
     cur_data = id,

R/shiny.R

@@ -48,12 +48,13 @@ renderPlotly <- function(expr, env = parent.frame(), quoted = FALSE) {
 #' }
 
 event_data <- function(event = c("plotly_hover", "plotly_click", "plotly_selected", 
-                                 "plotly_relayout"), source = "A") {
-  session <- shiny::getDefaultReactiveDomain()
+                                 "plotly_relayout"), source = "A",
+                       session = shiny::getDefaultReactiveDomain()) {
   if (is.null(session)) {
     stop("No reactive domain detected. This function can only be called \n",
          "from within a reactive shiny context.")
   }
-  val <- session$input[[sprintf(".clientValue-%s-%s", event[1], source)]]
+  src <- sprintf(".clientValue-%s-%s", event[1], source)
+  val <- session$rootScope()$input[[src]]
   if (is.null(val)) val else jsonlite::fromJSON(val)
 }

inst/examples/plotlyShinyModules/app.R

@@ -0,0 +1,48 @@
+library(shiny)
+library(plotly)
+
+reusableUI <- function(id = NULL) {
+  ns <- NS(id)
+
+  fluidRow(
+    column(4, plotlyOutput(ns("p1"))),
+    column(4, plotlyOutput(ns("p2"))),
+    column(4, verbatimTextOutput(ns("ev1"))),
+    column(4, verbatimTextOutput(ns("ev2")))
+  )
+}
+
+viz <- function(input, output, scope, src) {
+
+  # if you want, you can define multiple sources here
+  src2 <- paste0(src, "2")
+
+  output$p1 <- renderPlotly({
+    plot_ly(mtcars, x = ~mpg, y = ~disp, 
+            key = row.names(mtcars), source = src)
+  })
+  output$p2 <- renderPlotly({
+    plot_ly(mtcars, x = ~mpg, y = ~disp, 
+            key = row.names(mtcars), source = src2)
+  })
+  output$ev1 <- renderPrint({
+    event_data("plotly_hover", source = src)
+  })
+  output$ev2 <- renderPrint({
+    event_data("plotly_hover", source = src2)
+  })
+
+}
+
+ui <- fluidPage(
+  reusableUI("one"),
+  reusableUI("two")
+)
+
+server <- function(input, output, session) {
+  # use the src argument to namespace plotly events
+  callModule(viz, "one", src = "A")
+  callModule(viz, "two", src = "B")
+}
+
+shinyApp(ui, server)

inst/htmlwidgets/plotly.js

@@ -62,10 +62,8 @@ HTMLWidgets.widget({
           attachKey("key");
           return obj; 
         });
-        Shiny.onInputChange(
-          ".clientValue-" + eventType + "-" + x.source, 
-          JSON.stringify(d)
-        );
+        var src = ".clientValue-" + eventType + "-" + x.source;
+        Shiny.onInputChange(src, JSON.stringify(d));
       };
     };