No '.embed' extension for Jupyter embedded pages #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for #581 by adding '.embed' to plotly_iframe breaks compatibility with Jupyter.
The '.embed' extension is not added in all necessary places: New files are saved without the extension, and than they can't be loaded, because the iframe expects the extension.
However fixing this would still not work with Jupyter, as Jupyter does not render files with the extension '.embed'. It only renders if the extension is html otherwise it shows the contents as text.
This commit is a possible suggestion that allows fix #581 to remain valid and saves graphs for Jupyter without '.embed' extension.