Skip to content

add .embed to iframe #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2015
Merged

add .embed to iframe #243

merged 1 commit into from
Jul 31, 2015

Conversation

chriddyp
Copy link
Member

otherwise plotly will detect that the graph is in an iframe, and redirect to .embed anyway. so, this should make plotly embeds load ~2 seconds faster :)

cc @cpsievert

@cpsievert
Copy link
Collaborator

cool, thanks!

cpsievert added a commit that referenced this pull request Jul 31, 2015
@cpsievert cpsievert merged commit c799796 into carson-dsl Jul 31, 2015
@cpsievert cpsievert deleted the add-dot-embed-to-iframe branch July 31, 2015 15:13
@cpsievert
Copy link
Collaborator

The message below was automatically generated after build https://travis-ci.org/ropensci/plotly/builds/73571195

On TravisCI, commit 095c814 was successfully merged with 4b4f774 (master) to create 085e8f3. A visual testing table comparing 4b4f774 with 085e8f3 can be found here ->

http://cpsievert.github.io/plotly-test-table/R/085e8f3/

Detected 0 differences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants