Skip to content

Equal scaling of axes #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Equal scaling of axes #222

wants to merge 2 commits into from

Conversation

13bzhang
Copy link
Contributor

This pull request is a solution to fix Issue #218 "Equal scaling of axes not working". I fixed it so the width and height of Plotly plots have the ratios specified by ggplot2 user if they decide to specify coordinate ratios.

@mkcor
Copy link
Contributor

mkcor commented May 15, 2015

Aww a .Rhistory file should never end up in a PR... Please use

$ git add <file>
$ git commit -m "commit message"

(suspecting you used git commit -am ...?) but a .Rhistory file should never be tracked by your VCS in the first place. I'm not sure it's enough to remove it with an additional commit, because I wouldn't want it anywhere in our commit history.

@13bzhang Can you please submit a new PR and I'll close this one? Thank you so much!

@mkcor
Copy link
Contributor

mkcor commented May 15, 2015

Please add spacing around * operators and... I think the dotted notation is not our friend for simple variable names (the R culture is changing too: http://kbroman.org/hipsteR/).

@13bzhang 13bzhang closed this May 15, 2015
@13bzhang 13bzhang deleted the baobao-equal_axes branch May 15, 2015 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants