First stab at automated comments #208
Conversation
…after* merging with master
…ng of what we'll see after mergin with master
|
New test table created at http://ropensci.github.io/plotly-test-table/tables/00c78be43ec6af5576cdb7d2196aafe6286d4215/index.html |
|
Well, this ended up being more work than I anticipated... Note that the "dev" branch in the testing table should now reflect results after merging with master. I think this is a safer/better/right approach (new behavior could sneak in after merging) @chriddyp @mkcor @tdhock please review and let me know if you have any ideas for other comments/links that you’d like to be automatically posted. |
|
What do you call the "dev" branch? Do you mean the feature branch? There is no dev branch in continuous integration (https://github.com/ropensci/plotly/wiki/Development-guidelines#contributors-guide). 🐤 Reviewing now. Thanks for submitting, @cpsievert |
|
yea, I meant feature (not dev) branch |
|
Wow, very impressive! 💨 Ideally I would like to see these messages as posted by Good point on merging with master to see the actual final resulting images. Regarding the comment, maybe I would prefix it with something like "in the testing environment", otherwise a quick read might seem scary, like "Commit ab1967e was successfully merged into master..." wait, what? |
|
Thanks @mkcor 😊 Good point about the comment, maybe I'll just prefix with "On Travis, ..."? I agree it'd be nice to have these messages posted by a "bot". Unfortunately, I think that means we'll have to create a new user and grant it write access to this repo... |
|
wow, pretty sweet! |
|
Hold on, I might be able to create an organization that can post comments... |
|
Hmm, it seems as though I'd have to register a web application to post comments via an organization which seems like overkill (not to mention more complicated). I suppose I could create a new user, but someone (Karthik?) would have to grant write access to that user... |
|
@cpsievert It might not be worth the trouble, indeed. Then maybe the comment can start with this line and end with to catch our visual attention, and it's no big deal to have it posted by 'you'. 👍 for "On Travis, ..." |
On TravisCI, commit f3b40a7 was successfully merged with fafbff9 (master) to create df4f336. A visual testing table comparing fafbff9 with df4f336 can be found here: |
|
OK, I think I'm happy with the format of the comment now. Feel free to let me know what you think! |
|
Getting really stylish! |
First stab at automated comments
Once completed, this will close #207