Allowed for user defined axis positions. Closes #2029 #2039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the user can define the axis positions directly from
ggplot
.the
side
child element ofaxisObj
was not being set making plotly use the defaults. I added the entry and used ggplot'sget_scales
function to get the scale for each axis then the position. @cpsievert can you please approve this PR? the tests that failed are related to a missing api key