Skip to content

geom_density() as filled area chart #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 17, 2015
Merged

geom_density() as filled area chart #202

merged 6 commits into from
Apr 17, 2015

Conversation

cpsievert
Copy link
Collaborator

See #199.

@cpsievert cpsievert changed the title Carson density geom_density() as filled area chart Apr 13, 2015
@cpsievert
Copy link
Collaborator Author

@tdhock
Copy link
Contributor

tdhock commented Apr 14, 2015

Nice tests, and yeah that it weird about the difference between the rendered plotlys.

@alexcjohnson do you have any idea why this same plotly is rendered differently in these two cases?

@cpsievert
Copy link
Collaborator Author

I don't think I can do anything to fix the problem above, so I'd prefer to merge, then post that rendering issue somewhere more appropriate. Any ideas on where that might be @chriddyp @mkcor @tdhock?

Please review and +1 when you get a chance.

@alexcjohnson
Copy link
Collaborator

Ah, apologies for not looking at this before. I just did tried "fork and edit" and didn't see a change... but I can imagine where it could come from. The issue is the null at the end of the x array in the first trace. You're right that this shouldn't break it like this, so I'll open an issue for it on the plotly side - but I also imagine it's not quite what you had in mind here...

@cpsievert
Copy link
Collaborator Author

Nice, thanks for catching this @alexcjohnson!

I'll push a fix shortly.

@cpsievert
Copy link
Collaborator Author

@@ -1,15 +1,45 @@
context("Probability density")

expect_traces <- function(gg, n.traces, name){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after closing ).

@mkcor
Copy link
Contributor

mkcor commented Apr 16, 2015

Nice work, @cpsievert !
I only spotted a missing whitespace. Up to that, that's a +1 from me.

cpsievert added a commit that referenced this pull request Apr 17, 2015
geom_density() as filled area chart
@cpsievert cpsievert merged commit fafbff9 into master Apr 17, 2015
@cpsievert cpsievert deleted the carson-density branch April 17, 2015 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants