-
Notifications
You must be signed in to change notification settings - Fork 633
geom_density() as filled area chart #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New tests -- Something strange is happening with the density-fill example. If I click on "fork and edit", it takes me to another page that renders the plot correctly Could this be some sort of bug with plotly itself @chriddyp @mkcor ? |
Nice tests, and yeah that it weird about the difference between the rendered plotlys. @alexcjohnson do you have any idea why this same plotly is rendered differently in these two cases? |
Ah, apologies for not looking at this before. I just did tried "fork and edit" and didn't see a change... but I can imagine where it could come from. The issue is the |
Nice, thanks for catching this @alexcjohnson! I'll push a fix shortly. |
Everything looks good now! |
@@ -1,15 +1,45 @@ | |||
context("Probability density") | |||
|
|||
expect_traces <- function(gg, n.traces, name){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space after closing )
.
Nice work, @cpsievert ! |
geom_density() as filled area chart
See #199.