Skip to content

Update to plotly.js v2.5.1 #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Breaking changes in JavaScript API

* This version of the R package upgrades the version of the underlying plotly.js library from v1.57.1 to v2.2.1. This includes many breaking changes, bug fixes, and improvements to the underlying JavaScript library. The [plotly.js release page](https://github.com/plotly/plotly.js/releases) has the full list of changes.
* This version of the R package upgrades the version of the underlying plotly.js library from v1.57.1 to v2.5.1. This includes many breaking changes, bug fixes, and improvements to the underlying JavaScript library. The [plotly.js release page](https://github.com/plotly/plotly.js/releases) has the full list of changes.

## Breaking changes in R API

Expand Down
2 changes: 1 addition & 1 deletion R/plotly.R
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ typedArrayPolyfill <- function() {
plotlyMainBundle <- function() {
htmltools::htmlDependency(
name = "plotly-main",
version = "2.2.1",
version = "2.5.1",
package = "plotly",
src = dependency_dir("plotlyjs"),
script = "plotly-latest.min.js",
Expand Down
Binary file modified R/sysdata.rda
Binary file not shown.
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
{
"input": {
".clientValue-default-plotlyCrosstalkOpts": {
"on": "plotly_click",
"persistent": false,
"dynamic": false,
"selectize": false,
"opacityDim": 0.2,
"selected": {
"opacity": 1
},
"debounce": 0,
"color": [

]
},
"plotly_afterplot-A": "\"plot\"",
"plotType": "ggplotly"
},
"output": {
Expand Down Expand Up @@ -443,9 +458,9 @@
},
{
"name": "plotly-htmlwidgets-css",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-htmlwidgets-css-2.2.1"
"href": "plotly-htmlwidgets-css-2.5.1"
},
"meta": null,
"script": null,
Expand All @@ -456,9 +471,9 @@
},
{
"name": "plotly-main",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-main-2.2.1"
"href": "plotly-main-2.5.1"
},
"meta": null,
"script": "plotly-latest.min.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -460,9 +460,9 @@
},
{
"name": "plotly-htmlwidgets-css",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-htmlwidgets-css-2.2.1"
"href": "plotly-htmlwidgets-css-2.5.1"
},
"meta": null,
"script": null,
Expand All @@ -473,9 +473,9 @@
},
{
"name": "plotly-main",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-main-2.2.1"
"href": "plotly-main-2.5.1"
},
"meta": null,
"script": "plotly-latest.min.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,9 @@
},
{
"name": "plotly-htmlwidgets-css",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-htmlwidgets-css-2.2.1"
"href": "plotly-htmlwidgets-css-2.5.1"
},
"meta": null,
"script": null,
Expand All @@ -477,9 +477,9 @@
},
{
"name": "plotly-main",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-main-2.2.1"
"href": "plotly-main-2.5.1"
},
"meta": null,
"script": "plotly-latest.min.js",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -465,9 +465,9 @@
},
{
"name": "plotly-htmlwidgets-css",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-htmlwidgets-css-2.2.1"
"href": "plotly-htmlwidgets-css-2.5.1"
},
"meta": null,
"script": null,
Expand All @@ -478,9 +478,9 @@
},
{
"name": "plotly-main",
"version": "2.2.1",
"version": "2.5.1",
"src": {
"href": "plotly-main-2.2.1"
"href": "plotly-main-2.5.1"
},
"meta": null,
"script": "plotly-latest.min.js",
Expand Down
24 changes: 14 additions & 10 deletions inst/htmlwidgets/lib/plotlyjs/plotly-latest.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-heatmap/heatmap-discrete.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-heatmap/heatmap-midpoint.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-heatmap/heatmap.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-hex/hex-basic.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-hex/hex-bins.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-hex/hex-binwidth.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-histogram/histogram-fill.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-map/map-facet.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-path/path-colors.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/ggplot-sf/sf-fill-text.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/plotly-colorbar/plotly-colorbar.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/plotly-colorscale/colorramp.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/_snaps/plotly/plotly-alpha-blending.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions tools/update_plotlyjs.R
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ withr::with_dir(tmpdir, {

# build just the main bundle
# (also builds schema and locales)
system("npm update")
system("npm install")
system("npm run bundle")

Expand Down