Skip to content

Fix ggplotly error with NULL axis labs #1732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Fix ggplotly error with NULL axis labs #1732

wants to merge 8 commits into from

Conversation

doorisajar
Copy link

Resolves #1731

@doorisajar doorisajar mentioned this pull request Mar 30, 2020
Closed
cpsievert
cpsievert reviewed Mar 30, 2020
View reviewed changes
cpsievert
cpsievert reviewed Mar 30, 2020
View reviewed changes
@cpsievert
Copy link
Collaborator

What happened in 3d99fad? Can you fix the diff on R/ggplotly.R?

@doorisajar
Copy link
Author

doorisajar commented Mar 31, 2020 •
edited
Loading

What happened in 3d99fad? Can you fix the diff on R/ggplotly.R?

Looks like there's no line endings specification in the Rproj file, so when I switched from editing things in the GitHub interface to editing them in RStudio on Windows, the line endings got changed and I didn't notice. Just attempted to revert that in de198b4...

Update: Looks like that worked. The diffs look as expected now. Sorry for the runaround on what turned out to be a relatively straightforward change!

@cpsievert
Copy link
Collaborator

I'd still prefer to use length() directly over rlang::is_empty() as I more regularly use the former

@doorisajar
Copy link
Author

I'd still prefer to use length() directly over rlang::is_empty() as I more regularly use the former

In case you didn't see the commit, I did make this change.

@cpsievert
Copy link
Collaborator

Thanks for contributing this fix! It had some overlap with #1773 so we incorporated it there

@cpsievert cpsievert closed this May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ggplotly error when xlab is element_blank()
2 participants
@doorisajar @cpsievert